Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from wasm-based hpke-dispatch to hpke-js #384

Merged
merged 1 commit into from
Aug 31, 2023
Merged

switch from wasm-based hpke-dispatch to hpke-js #384

merged 1 commit into from
Aug 31, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Aug 23, 2023

No description provided.

@coveralls
Copy link

coveralls commented Aug 23, 2023

Pull Request Test Coverage Report for Build 6016401082

  • 45 of 48 (93.75%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 90.747%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/dap/src/index.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
packages/dap/src/hpkeConfig.ts 3 97.3%
Totals Coverage Status
Change from base Build 6016377909: -0.1%
Covered Lines: 3433
Relevant Lines: 3746

💛 - Coveralls

Comment on lines +94 to +96
const aead: AeadId = this.aeadId as AeadId;
const kdf: KdfId = this.kdfId as KdfId;
const kem: KemId = this.kemId as KemId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selectConfig() expects this to be fallible, throwing when the algorithms are not supported. However, the constructor also checks that algorithms are supported when constructing an HpkeConfig, which would prevent us from deserializing an HpkeConfigList with algorithms we don't recognize, so this is moot for now. I'll file an issue to improveme this separately.

@jbr jbr merged commit ada3fe3 into main Aug 31, 2023
4 checks passed
@jbr jbr deleted the hpke-js branch August 31, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants