Allow base64 padding characters in bearer tokens #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we really need to validate them at all? I've historically just treated them as opaque ascii/utf8, which I understand isn't exactly in compliance with the spec but there also isn't any reason divviup-api needs to be enforcing the bearer token spec here; we're just passing around bytes between other parties. This may be a topic to further discuss when Tim is back, so let's merge this in the meantime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base64 custom validator is too strict for the aggregator API's purposes, as it doesn't allow
=padding characters. Janus currently expects to be able to decode aggregator API bearer tokens with theSTANDARDbase64 engine, so bearer tokens must end with two padding characters, given the token length we chose. This PR adds=to the validator's allowed alphabet.