Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation of development environment setup #86

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

divergentdave
Copy link
Contributor

No description provided.

@divergentdave divergentdave requested a review from a team as a code owner January 30, 2024 17:26
@inahga
Copy link
Contributor

inahga commented Jan 30, 2024

I'm giving this a try on both my systems, will LYK how that goes.

Copy link
Contributor

@inahga inahga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked great on MacOS, modulo some Docker woes noted in my review. I don't like to use Docker Desktop because its restrictive license scares me, but luckily the Java Testcontainers does have support for alternative runtimes.

This mostly worked on Linux. I ran into a dynamic linking problem with clang, but this is due to my esoteric choice of Linux distribution, NixOS. The "proper" way to get this to work on NixOS is to have a Nix shell rather than having the Android SDK installed globally. I will pursue this separately. Just making a note in writing in case someone else comes along and has this problem.

performance difference between using a processor architecture that matches the
host (which can be virtualized) versus using a dissimilar processor architecture
(which must be emulated).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Docker
If you're using an alternative Docker runtime, such as `podman` or `colima`, set up
your environment according to the [Testcontainers documentation][testcontainers].
[testcontainers]: https://java.testcontainers.org/supported_docker_environment/

Caveat: the suggestion might not fit in correctly, suggest taking it in an editor rather than directly committing it.

@divergentdave divergentdave merged commit 2a6238f into main Jan 31, 2024
2 checks passed
@divergentdave divergentdave deleted the david/contributing-docs branch January 31, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants