Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules sol #58

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Rules sol #58

wants to merge 3 commits into from

Conversation

alexeagle
Copy link
Contributor

No description provided.

This ensures that all developers have the same version of bazel as the CI machine.
Especially important if we decide to upgrade the version used, so devs aren't broken by missing features.
Note, Bazelisk, as well as Bazel's wrapper script you get from the installer, will check this file to prevent a wrong Bazel from running.
If we want a stronger guarantee, we can follow
https://github.com/bazelbuild/bazelisk#ensuring-that-your-developers-use-bazelisk-rather-than-bazel
Avoids version skew where some rule transitively installs an older bazel-skylib
Copy link

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@gregmagolan
Copy link

Whoops. Nevermind the stamp. I thought I was stamping aspect-build/rules_sol#1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants