Fixing some minor bugs found in backend #57
Conversation
| for(const i in discoveredInfo){ | ||
| if(!(await models.tag.exists(discoveredInfo[i]))) | ||
| await models.tag.create({tagname: discoveredInfo[i], creator: username}); | ||
| await models.userTag.create({ username, tagname: discoveredInfo[i], story: 'story' ,relevance: 5}); |
There was a problem hiding this comment.
a space should be after coma (i.e. story: 'story', relevance: ...)
| should(tags).containEql('ditup-spirit-WTF'); | ||
| }); | ||
|
|
||
| it('do not add special tags if not playing with some people', async function () { |
| tags = tags.map((userTag) => {return userTag.tag.tagname;}); | ||
| should(tags).not.containEql('some-strange-books'); | ||
| should(tags).not.containEql('it-is-possible-to-eat-a-lot-and-not-get-fat'); | ||
| should(tags).not.containEql('should-I-leave-my-job'); |
There was a problem hiding this comment.
I in uppercase may be confusing (the tagnames should be in lowercase)
|
Nice catches @agatatalita ! 👍 The code is currently running live at https://dev.ditup.org. |
|
There is a security issue: It would be possible to find |
|
It is a good point @ yanka (ups, other yanka). I don't see a good way in which we can get a nice reaction that we are close to yanka and keep yanka's location not discovered. It seems to be always a trade between accuracy and not showing the accurate location. |
|
Stil wondering whether you cannot do the similar thing with the fuzzy location. Will we not get just a ring around our place? @mrkvon and @yanka2 |
|
This is a great work. |
|
Did we(ha!) just skipped my question about the fuzzy location? |
|
The fuzzy location works as follows: Whenever you update your |
|
OK, that is great, I was worried it makes it random every time. Let's correct it and merge with master. Thank you for your explanation. |
|
This was fun. |
|
Just one only one piece of fix. Just this very very little one. |
No description provided.