dwarf: fix inline calls reporting #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally implement the original TODO of checking whether the PC being symbolized actually belong to the the inline function to add to locations, instead of adding all functions inlined in the caller, regardless of location. Also, correctly classify whether a location is the result of an inline call. The rust test is updated for the same reason. Also make sure tests are compiled with -g.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally implement the original TODO of checking whether the PC being symbolized actually belong to the inline function to add to locations instead of adding all functions inlined in the caller, regardless of location. Also, correctly classify whether a location is the result of an inline call.
The rust test is updated for the same reason.
Also make sure tests are compiled with -g.
Fixes #94