Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove globals #89

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Remove globals #89

merged 2 commits into from
Jul 27, 2023

Conversation

brendandburns
Copy link
Contributor

@achille-roussel

This removes all of the various global maps and fixes #87

achille-roussel
achille-roussel approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, thanks for the fix!

@brendandburns
Copy link
Contributor Author

Thanks for merging the server code! Rebased this PR to remove the globals from that code too.

achille-roussel
achille-roussel approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clear 👍

@achille-roussel achille-roussel merged commit 43bb9af into dispatchrun:main Jul 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achille-roussel achille-roussel achille-roussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential concurrent map read writes errors
3 participants
@brendandburns @achille-roussel @brendanburns