socket: long options #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows SockSetOpt to accept arbitrary values (that are not only int32). Also adds a new "reserved" socket option level.
| return Errno(wasi.ENOTSUP) | ||
|
|
||
| default: | ||
| val = wasi.StringValue(value) |
There was a problem hiding this comment.
Should we have a BytesValue instead? I feel like StringValue implies it's UTF-8 but since this is a fallback it could be anything.
There was a problem hiding this comment.
Given the level of the stack we're operating at, StringValue implies that it's a null-terminated string rather than a utf-8 encoded string. BytesValue to me reads that it may contain a null byte and so length is supplied separately.
There was a problem hiding this comment.
At this point of the code we failed to recognized the option and will just pass the bytes as-is to the wasi.System, so it may contain null bytes?
chriso
suggested changes
Jun 27, 2023
chriso
approved these changes
Jun 27, 2023
achille-roussel
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes two main changes:
SockSetOpt.SockSetOptandSockGetOptto merge option and level into one value.The main goal is to enable extensions of socket options by the implementations of
wasi.System, without having to teach wasi-go about them.