addrinfo: use default resolver #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achille Roussel <[email protected]>
Signed-off-by: Achille Roussel <[email protected]>
Signed-off-by: Achille Roussel <[email protected]>
pelletier
reviewed
Jun 25, 2023
| if err != nil { | ||
| return 0, wasi.ECANCELED // TODO: better errors on name resolution failure | ||
| } | ||
|
|
||
| addrs := make([]wasi.AddressInfo, 0, 16) | ||
| addrs4 := make([]wasi.AddressInfo, 0, 8) | ||
| addrs6 := make([]wasi.AddressInfo, 0, 8) |
There was a problem hiding this comment.
I'm confused about this. Why have two slices? or why not append directly into results?
There was a problem hiding this comment.
There are two slices so that we can put all the IPv4 addresses first; this is a cheaper and simpler way to do the partial ordering that was implemented with a stable sort in the previous version.
results is an output parameter, we can't append to the slice, which is why we use copy after collecting the addresses.
There was a problem hiding this comment.
Ah I forgot about the need to have ipv4 first 👍🏻
pelletier
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
wasirunto usenet.DefaultResolverso we can configure the DNS servers forSockAddressInfoand propagate the context for asynchronous cancellation.