addrinfo: fix address ordering #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achille Roussel <[email protected]>
chriso
approved these changes
Jun 23, 2023
pelletier
approved these changes
Jun 23, 2023
Merged
achille-roussel
added a commit
that referenced
this pull request
Jun 23, 2023
Follow up to #68, the address family was never set. Signed-off-by: Achille Roussel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a bit more determinism in the behavior of the name resolver.
There were a few issues:
I also added a partial sort of the results so that we put the AF_INET addresses first when they are mixed with AF_INET6 due to the hint being AF_UNSPEC, this helps keep the behavior deterministic; for example, if the client uses the first address that it is returned, it doesn't result in sometimes connecting to an IPv4 and sometimes an IPv6.