fix: custom_labels on SidekiqStatsCollector and SidekiqProcessCollector #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarany
changed the title
mbarany
force-pushed
the
fix-custom-labels-on-sidekiq-stats-collector
branch
from
37e3e56 to
9079be1
Compare
|
@SamSaffron this is ready for review. thanks |
|
I am a bit confused, when did the shape of the data change to include the "process" key? will this break old installs? also tests appear to be failing |
|
I fixed the tests. In |
|
bump ^ @SamSaffron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196