Reentrant script #35
Open
Reentrant script #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the script multiple times (because, say, ruby won't install properly), it will fail to start Postgres if it's already started. I believe this version of the command works whether Postgres has been started in the past or not.
Restart rather than start Postgres
If you already have the designated version of Ruby, just skip this step. Without this option, you must wait for Ruby to be needlessly reinstalled each time you run the script. No real risk to skipping unless you have a screwed up install in the first place.
Skip if Ruby version already installed
Doesn't throw an error if Redis is already started, but doesn't update to the latest Redis if it's just been installed. (See: discourse/prometheus_exporter#250)
Restart rather than start Redis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run the script once, it starts PostgreSQL so that the second time you run it the script fails. The solutions is to use
restartrather thanstart. That way it will ensure the sever is started whether or not it's already running. (One possible downside is if you don't want PostgreSQL to go down because you've installed Discourse. In that case, you probably shouldn't be using this script.)There's also a prompt to reinstall Ruby that means you must reinstall or the scrip will just stop. Add the
-soption skips installation if rbenv sees that version is already installed.Finally, I changed from
starttorestartfor the Redis server too. It doesn't fail if Redis is already running, but if you happen to update Redis, that update won't go into effect until you restart the server.