Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: parameterize config filename #872

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

featheredtoast
Copy link
Member

Parameterize which filename to write to (write config) and which file is copied from (dockerfile)

featheredtoast added a commit to featheredtoast/discourse-launcher-extras that referenced this pull request Sep 22, 2024
depends on discourse/discourse_docker#872 to be merged
first for parameterization
Parameterize the config filename for writing config to and expected file to be
copied from in resulting dockerfiles
@tgxworld
Copy link
Contributor

tgxworld commented Oct 16, 2024

@featheredtoast Just from the PR description, I can't deduce why this change is required. Will you be able to update the PR description to reflect the "why"? Thank you 🙇

@featheredtoast
Copy link
Member Author

@tgxworld this one allows for external tools to parameterize where the config.yaml file gets written to, and picked up in a dockerfile, rather than being hardcoded as config.yaml

I've got a proof-of-concept write-config-to-docker-compose that could take advantage of this, that allows an export of a 2-container setup to a docker-compose. Without it, I realized there isn't a good way to do something like print multiple config.yaml config files and their dockerfiles to the same location.

Experimental branch here takes advantage of this: featheredtoast/discourse-launcher-extras@33d98b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants