Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactions): add launchActivity method #10646

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Dec 8, 2024

Please describe the changes this PR makes and why it should be merged:
#10640 but for core

Depends on

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 1:07pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 1:07pm

packages/core/src/api/interactions.ts Outdated Show resolved Hide resolved
packages/core/src/api/interactions.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 37.11%. Comparing base (bc3a0c8) to head (665ef62).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/api/interactions.ts 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10646      +/-   ##
==========================================
- Coverage   37.91%   37.11%   -0.81%     
==========================================
  Files         239      239              
  Lines       14877    15144     +267     
  Branches     1376     1370       -6     
==========================================
- Hits         5641     5620      -21     
- Misses       9225     9513     +288     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imnaiyar and others added 2 commits January 3, 2025 19:05
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jiralite <[email protected]>
@imnaiyar imnaiyar requested a review from Jiralite January 3, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

2 participants