New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(InteractionResponses)!: support with_response query parameter #10499

Merged

didinele merged 19 commits into discordjs:main from monbrey:with_response

Nov 28, 2024

Member

monbrey commented Sep 12, 2024 •

edited by Jiralite

Loading

Please describe the changes this PR makes and why it should be merged:
Closes #10498

/core done in #10512

Upstream: discord/discord-api-docs#7106

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating
This PR changes the library's interface (methods or parameters added)

monbrey requested review from a team and iCrawl as code owners

September 12, 2024 03:59

monbrey requested review from vladfrangu, kyranet and SpaceEEC

September 12, 2024 03:59

vercel bot commented Sep 12, 2024 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
discord-js	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 28, 2024 8:28am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
discord-js-guide	⬜️ Ignored (Inspect)	Visit Preview		Nov 28, 2024 8:28am

github-actions bot added the packages:discord.js label

Member

Jiralite commented Sep 12, 2024 •

edited

Loading

This also required a discord-api-types version bump

We'll wait for #10488 before this one lands.

Jiralite reviewed

View reviewed changes

Member

Jiralite left a comment

I see the interaction callback resource contains any message created. If this is a good enough alternative to options.fetchReply, I say we should deprecate it.

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

vladfrangu previously requested changes

View reviewed changes

packages/discord.js/package.json Outdated Show resolved Hide resolved

packages/discord.js/src/index.js Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallbackResponse.js Outdated Show resolved Hide resolved

vladfrangu added semver:minor blocked labels

vladfrangu added this to the discord.js 14.17 milestone

vercel bot deployed to Preview – discord-js

September 17, 2024 22:07

View deployment

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (cda8d88) to head (8b69bd4).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10499      +/-   ##
==========================================
+ Coverage   35.48%   35.49%   +0.01%     
==========================================
  Files         228      228              
  Lines       14308    14303       -5     
  Branches     1254     1254              
==========================================
  Hits         5077     5077              
+ Misses       9187     9182       -5     
  Partials       44       44

Flag	Coverage Δ
guide	`0.54% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

monbrey mentioned this pull request

feat(interactions): support with_response query parameter in core #10512

Merged

didinele dismissed vladfrangu’s stale review

September 18, 2024 14:38

stale

vladfrangu removed the blocked label

Member

Jiralite commented Oct 2, 2024

Please resolve conflicts!

Jiralite previously requested changes

View reviewed changes

Member

Jiralite left a comment

Please resolve conflicts!

packages/discord.js/src/structures/InteractionCallbackResponse.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

Jiralite modified the milestones: discord.js 14.17, discord.js 15.0.0

sdanialraza requested changes

View reviewed changes

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallbackResponse.js Show resolved Hide resolved

packages/discord.js/src/structures/interfaces/InteractionResponses.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/interfaces/InteractionResponses.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/interfaces/InteractionResponses.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/interfaces/InteractionResponses.js Outdated Show resolved Hide resolved

almeidx previously requested changes

View reviewed changes

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallbackResource.js Show resolved Hide resolved

cobaltt7 reviewed

View reviewed changes

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved

monbrey and others added 5 commits

November 14, 2024 10:08


          feat(InteractionResponses): support with_response query parameter

fb02e8a


          fix: export new files from index

a9a5872


          Apply suggestions from code review

bd6d5b0

Co-authored-by: Jiralite <[email protected]>


          fix: correct assignment of nullable property, types

dd642d7


          fix: exports

c5a4696

Jiralite dismissed vladfrangu’s stale review

November 17, 2024 00:43

Resolved.

Jiralite requested a review from vladfrangu

November 17, 2024 00:44


          fix: apply suggestions from code review

2637c17

Co-authored-by: Jiralite <[email protected]>

Jiralite requested changes

View reviewed changes

packages/discord.js/typings/index.d.ts Show resolved Hide resolved

packages/discord.js/src/structures/interfaces/InteractionResponses.js Show resolved Hide resolved

monbrey added 3 commits

November 18, 2024 06:20


          fix: types and docs

00bae08


          Merge branch 'with_response' of https://github.com/monbrey/discord.js …

c2bdd14

…into with_response


          Merge branch 'main' into with_response

d3b8266

Jiralite previously requested changes

View reviewed changes

Member

Jiralite left a comment

showModal() on CommandInteraction is missing options. I'm pretty sure it should be there, no?

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved

packages/discord.js/src/structures/InteractionCallback.js Outdated Show resolved Hide resolved

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved

Jiralite added the interactions label

monbrey and others added 2 commits

November 25, 2024 12:53


          fix: apply suggestions from code review

677d615

Co-authored-by: Jiralite <[email protected]>


          fix: commandinteraction#showModal types

6c18aff

Jiralite added semver:major and removed semver:minor labels

Jiralite changed the title ~~feat(InteractionResponses): support with_response query parameter~~ feat(InteractionResponses)!: support with_response query parameter

Jiralite requested a review from sdanialraza

November 27, 2024 17:24

Jiralite dismissed their stale review

November 27, 2024 17:24

Resolved.

Jiralite previously requested changes

View reviewed changes

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved


          fix: swap overloads

8775fbd

Jiralite dismissed their stale review

November 27, 2024 22:28

Resolved.

Jiralite self-requested a review

November 27, 2024 22:28

Jiralite approved these changes

View reviewed changes

didinele approved these changes

View reviewed changes

vladfrangu approved these changes

View reviewed changes


          Merge branch 'main' into with_response

d1e9bce

vercel bot deployed to Preview – discord-js

November 28, 2024 08:28

View deployment

didinele merged commit 2b0944a into discordjs:main

7 checks passed

This was referenced Nov 29, 2024

feat: discord.js v15 discordjs/guide#1595

Draft

feat(InteractionResponses): support with_response query parameter #10636

Merged

Jiralite added the api support label

Jiralite mentioned this pull request

types(InteractionReplyOptions): Add withResponse #10637

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cobaltt7 cobaltt7 left review comments

vladfrangu vladfrangu approved these changes

didinele didinele approved these changes

Jiralite Jiralite approved these changes

iCrawl Awaiting requested review from iCrawl

kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

almeidx Awaiting requested review from almeidx

sdanialraza Awaiting requested review from sdanialraza

Labels

api support interactions packages:discord.js semver:major