Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update uri for Tempest lib in community resources #6626

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

amatsagu
Copy link
Contributor

@amatsagu amatsagu commented Jan 21, 2024

I've recently renamed all my projects to use lowercase titles so it's more aligned with typical github project. Old redirection will only work for week or two so it should be updated till then. Thanks!

I've recently renamed all my projects to use lowercase titles so it's more aligned with typical github project. Old redirection will only work for week or two so it shou;d be updated till then. Thanks!
@splatterxl
Copy link
Contributor

splatterxl commented Jan 21, 2024

GitHub doesn't specify a time limit for redirects regarding repository renames.

When you rename a repository, all existing information, with the exception of project site URLs, is automatically redirected to the new name. (ref)

Additionally, casing in GitHub URLs don't matter: https://github.com/dISCORD/Discord-API-Docs will work just fine, for example.

@amatsagu
Copy link
Contributor Author

GitHub doesn't specify a time limit for redirects regarding repository renames.

When you rename a repository, all existing information, with the exception of project site URLs, is automatically redirected to the new name. 1

Additionally, casing in GitHub URLs don't matter: https://github.com/dISCORD/Discord-API-Docs will work just fine, for example.

That's something new, ok nice - thanks for info!
When I did rename my accout nickname to use lowerspace it did warn me that it may break all existing links to my profile and/or repositories. I guess this pull request is not required then but I would still feel better having updated uri for my own sanity.

@thewilloftheshadow
Copy link
Contributor

That's something new, ok nice - thanks for info! When I did rename my accout nickname to use lowerspace it did warn me that it may break all existing links to my profile and/or repositories.

That's just because if you change your name completely then someone can use the old name after a certain amount of time, and they use that message regardless of what in your name changed

@jhgg jhgg merged commit ecb5818 into discord:main Mar 6, 2024
3 checks passed
shaydewael pushed a commit to Jupith/discord-api-docs that referenced this pull request May 14, 2024
I've recently renamed all my projects to use lowercase titles so it's more aligned with typical github project. Old redirection will only work for week or two so it shou;d be updated till then. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants