-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thread/forum channel docs regression #6546
Merged
colinloretz
merged 3 commits into
discord:main
from
colinloretz:fix/missing-threads-info
Nov 27, 2023
Merged
Fix thread/forum channel docs regression #6546
colinloretz
merged 3 commits into
discord:main
from
colinloretz:fix/missing-threads-info
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gesendet von Outlook für Android<https://aka.ms/AAb9ysg>
…________________________________
Von: Colin Loretz ***@***.***>
Gesendet: Montag, November 27, 2023 7:34:08 PM
An: discord/discord-api-docs ***@***.***>
Cc: Subscribed ***@***.***>
Betreff: [discord/discord-api-docs] Fix thread/forum channel docs regression (PR #6546)
Fix doc regression for forum/media channels.
Thanks to @lukellmann<https://github.com/lukellmann> for the catch! #5478 (comment)<#5478 (comment)>
________________________________
You can view, comment on, or merge this pull request online at:
#6546
Commit Summary
* 2e193e0<2e193e0> Fix thread content regression
File Changes
(1 file<https://github.com/discord/discord-api-docs/pull/6546/files>)
* M docs/resources/Channel.md<https://github.com/discord/discord-api-docs/pull/6546/files#diff-160acb4654c611c67c4ee46b2ce5dda2be82212af8d1d00cd0256ef6edda1e95> (22)
Patch Links:
* https://github.com/discord/discord-api-docs/pull/6546.patch
* https://github.com/discord/discord-api-docs/pull/6546.diff
—
Reply to this email directly, view it on GitHub<#6546>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFPIADIJMP6QM4MOYRIDALYGTMJ7AVCNFSM6AAAAAA74PJ7OGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTEOBWGMYDEMI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
lukellmann
reviewed
Nov 27, 2023
Co-authored-by: Luca Kellermann <[email protected]>
Gesendet von Outlook für Android<https://aka.ms/AAb9ysg>
________________________________
From: Luca Kellermann ***@***.***>
Sent: Monday, November 27, 2023 7:36:39 PM
To: discord/discord-api-docs ***@***.***>
Cc: Miami87 ***@***.***>; Comment ***@***.***>
Subject: Re: [discord/discord-api-docs] Fix thread/forum channel docs regression (PR #6546)
@lukellmann commented on this pull request.
________________________________
In docs/resources/Channel.md<#6546 (comment)>:
@@ -1352,15 +1352,15 @@ Creates a new thread in a forum or a media channel, and sends a message within t
info
When sending a message, apps must provide a value for **at least one of** `content`, `embeds`, `sticker_ids`, `components`, or `files[n]`.
-| Field | Type | Description |
-|-------------------|----------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| content?\* | string | Message contents (up to 2000 characters) |
-| embeds?\* | array of [embed](#DOCS_RESOURCES_CHANNEL/embed-object) objects | Embedded `rich` content (up to 6000 characters) |
-| allowed_mentions? | [allowed mention object](#DOCS_RESOURCES_CHANNEL/allowed-mentions-object) | Allowed mentions for the message |
-| components?\* | array of [message component](#DOCS_INTERACTIONS_MESSAGE_COMPONENTS/component-object) objects | Components to include with the message |
-| sticker_ids?\* | array of snowflakes | IDs of up to 3 [stickers](#DOCS_RESOURCES_STICKER/sticker-object) in the server to send in the message |
-| attachments? | array of partial [attachment](#DOCS_RESOURCES_CHANNEL/attachment-object) objects | Attachment objects with `filename` and `description`. See [Uploading Files](#DOCS_REFERENCE/uploading-files) |
-| flags? | integer | [Message flags](#DOCS_RESOURCES_CHANNEL/message-object-message-flags) combined as a [bitfield](https://en.wikipedia.org/wiki/Bit_field) (only `SUPPRESS_EMBEDS` can be set) |
+| Field | Type | Description |
+|-------------------|----------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| content?\* | string | Message contents (up to 2000 characters) |
+| embeds?\* | array of [embed](#DOCS_RESOURCES_CHANNEL/embed-object) objects | Up to 10 `rich` content (up to 6000 characters) |
⬇️ Suggested change
-| embeds?\* | array of [embed](#DOCS_RESOURCES_CHANNEL/embed-object) objects | Up to 10 `rich` content (up to 6000 characters) |
+| embeds?\* | array of [embed](#DOCS_RESOURCES_CHANNEL/embed-object) objects | Up to 10 `rich` embeds (up to 6000 characters) |
—
Reply to this email directly, view it on GitHub<#6546 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFPIAFSLSESW4DLP63YFOLYGTMTPAVCNFSM6AAAAAA74PJ7OGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJRGEYTEMBWHA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
shaydewael
pushed a commit
to Jupith/discord-api-docs
that referenced
this pull request
May 14, 2024
* Fix thread content regression * Update docs/resources/Channel.md Co-authored-by: Luca Kellermann <[email protected]> * tables and rerun actions --------- Co-authored-by: Luca Kellermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix doc regression for forum/media channels.
Thanks to @lukellmann for the catch! #5478 (comment)