-
Notifications
You must be signed in to change notification settings - Fork 62
Notifications Update #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eguerrant
wants to merge
12
commits into
main
Choose a base branch
from
notifications_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Notifications Update #299
+945
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somethingnew2-0
requested changes
Jun 23, 2025
Voiced over, we should update the Slack example plugin as well We should also verify the example plugins install correctly as well as potentially verify the old version of the plugins ignore the new kwargs for backwards compatibility. |
This comment was marked as resolved.
This comment was marked as resolved.
somethingnew2-0
previously approved these changes
Jun 26, 2025
cb7a4b5
to
4e53fa6
Compare
savathoon
previously approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 seems backwards compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#300 : changes to the Access UI so that role owners are easily able to see roles they own that will be expiring soon under 'Expiring Roles' and will allow them to make a role request from that page