Skip to content

Notifications Update #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Notifications Update #299

wants to merge 12 commits into from

Conversation

eguerrant
Copy link
Contributor

@eguerrant eguerrant commented Jun 17, 2025

  • Change the expiring access notification functions to provide more specific information (eg. list of users who will be losing access to each group instead of just a list of users and a list of groups)
    • The goal is to be able to send notifications along the lines of ' will be losing access to ' instead of the current notifications that are limited more to vague messages like 'A user will lose access next week'
    • Made this change backwards compatible for now so any messages that use the old args should still work
  • Add notifications for role owners so that they know when roles they own will be losing access soon
  • Updated example notifications

#300 : changes to the Access UI so that role owners are easily able to see roles they own that will be expiring soon under 'Expiring Roles' and will allow them to make a role request from that page

@eguerrant eguerrant marked this pull request as ready for review June 17, 2025 21:47
somethingnew2-0

This comment was marked as resolved.

@somethingnew2-0
Copy link
Collaborator

Voiced over, we should update the Slack example plugin as well

We should also verify the example plugins install correctly as well as potentially verify the old version of the plugins ignore the new kwargs for backwards compatibility.

@somethingnew2-0

This comment was marked as resolved.

savathoon
savathoon previously approved these changes Jun 26, 2025
Copy link
Contributor

@savathoon savathoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 seems backwards compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants