Leap week page #84
Merged
Leap week page #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phazonoverload
requested review from
paescuj,
rijkvanzanten and
bryantgillespie
✅ Deploy Preview for directus-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Ben's feedback incorporated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This review doesn't need to be too thorough - this is a throwaway page.
There is still feedback from Ben waiting to be actioned, but they are all superficial. A quick glance over the code would be appreciated.
For context of the hardcoded token - don't panic! It's a standalone project, the token's user holds no permissions at all, but is needed to handshake with Directus Realtime. This is public permissions, which also do not have access to unreleased items.