Fix WebSocket rate limiter ignoring per-project Redis key prefix - #28106
Closed
AlexGaillard wants to merge 3 commits into
Closed
Fix WebSocket rate limiter ignoring per-project Redis key prefix#28106AlexGaillard wants to merge 3 commits into
AlexGaillard wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
websocket. On shared-Redis setups where each project can only touch keys starting with its own name, this blocked the project from reading its own limiter keys, so WebSocket rate limiting broke.RATE_LIMITER_WEBSOCKETS_*), matching how the other limiters already work.websocket(so nothing changes for existing setups) and can be overridden per project withRATE_LIMITER_WEBSOCKETS_KEY_PREFIX.Tested Scenarios
apibase.test.ts).Review Notes / Questions / Concerns
RATE_LIMITER_ENABLEDflag, so turning rate limiting on/off is unchanged.Checklist
@directus/specs)@directus/sdk) updated to reflect the changes@directus/types) updated to reflect the changes@directus/system-data) updated for changes to system collections/fields/relationsFixes CMS-2985