-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve telemetry with deeper insights into system usage #22337
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: dcf8332 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Pascal Jufer <[email protected]>
Co-authored-by: Daniel Biegler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ✨
- For the newly introduced data (db size, and especially fields count) do we expect them to perform well? Wondering after seeing this comment:
directus/api/src/telemetry/utils/get-item-count.ts
Lines 49 to 50 in b4645f7
// Counts can be a little heavy if the table is very large, so we'll only ever execute 3 of these // queries simultaneously to not overload the database - Just because it might be good to know (and maybe add inline docs): Do (some of) the DB size queries require some special DB permissions?
Co-authored-by: Pascal Jufer <[email protected]>
Tricky to map fields from older versions into the updated field names
Scope
What's changed:
fields_max
&fields_total
Potential Risks / Drawbacks
Review Notes / Questions
Fixes #21982