Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface refactor #343

Closed
wants to merge 3 commits into from
Closed

Interface refactor #343

wants to merge 3 commits into from

Commits on Sep 19, 2023

  1. Example refactoring

    @jeremykubica
    jeremykubica committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    07db050 View commit details
    Browse the repository at this point in the history

  2. Split up common.h

    @jeremykubica
    jeremykubica committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    16f58e4 View commit details
    Browse the repository at this point in the history

  3. Splitting bindings into multiple files. 

    Proposal on how to split Pybind bindings into multiple files for
readability. Implemented on the example of a PSF class.

The code currently doesn't work because we can not have multiple
entry point calls to the macro PYBIND11_MODULE in a single codebase.
Or at least I don't think we can and nothing I tried worked.
We certainly can not extend a once-declared module by repeatedly
calling PYBIND11_MODULE, but seemingly we can not define a new one
either.
    @DinoBektesevic
    DinoBektesevic committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b1ac016 View commit details
    Browse the repository at this point in the history