fix(anchors) Use scroll-padding for headings anchoring #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3y3
reviewed
Jul 26, 2023
styles/yfm.scss
Outdated
| h4, | ||
| h5, | ||
| h6 { | ||
| // Непонятно, как нормально переопределить селектор с &:first-child |
|
Please squash all to conventional commits |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача отчасти связанная с этим PR: diplodoc-platform/transform#254
Если в таблице отрендерить заголовок, то при клике в якорь этого заголовка страница подскроливается без учёта высоты стики-шапки. В этом PR предлагаю системно изменить решение для подскрола к любым заголовкам.
Есть CSS-свойство, предназначенное для этого:
scroll-padding.fixAnchorPositionубираю костылек с отрицательным марджином.fixAnchorPositionпереименовываю вsetHeadingPadding, потому что теперь он занимается лишь вычислением паддинга для заголовковТеперь подскроливается нативно.