-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable graceful fallback handling. #11
Open
nigeleke
wants to merge
20
commits into
dioxus-community:main
Choose a base branch
from
nigeleke:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,087
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just had a quick look and all I have to say is this is impressive work! Feature well explained, added tests, comments, and docs, very nice job! I'll have a longer look asap! 🦀 |
marc2332
requested changes
Jan 8, 2025
Reword LocaleResource comment Co-authored-by: Marc Espin <[email protected]>
Update comment for set_language Co-authored-by: Marc Espin <[email protected]>
Updated review comments commited online.
All comments taken onboard. @marc2332 this is my first formally reviewed PR, so not sure if you're expecting me to do a "completed changes" notification. I can't see any obvious action here on GH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a language_identifier does not have a direct translation in the config, it will be determined if one exists for the primary_language. If so, then that will be used, otherwise revert to the configured fallback. Eg: config contains "en" and "en-GB" but user has selected "en-US". "en-US" will not be found, so "en" will be used.
The graceful fallback hierarchy follows -<script>--, rolling from the RHS back to .
It is possible to "share" a translation resource:
where the included strings are not duplicated in the final config.
Other changes mentioned in CHANGELOG.
Note: v# bumped to 0.4.0
Closes #10