Merge pull request kruize#1460 from bharathappali/gpu-update-impl-3

KAMS - 3 : Adds support for MIG partition data in Device Details
dinogun · Feb 5, 2025 · 104a5fa · 104a5fa
2 parents e09c130 + 02ee261
commit 104a5fa
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 12 deletions.
diff --git a/src/main/java/com/autotune/analyzer/adapters/DeviceDetailsAdapter.java b/src/main/java/com/autotune/analyzer/adapters/DeviceDetailsAdapter.java
@@ -26,7 +26,8 @@ public void write(JsonWriter out, DeviceDetails value) throws IOException {
             out.name("hostName").value(accelerator.getHostName());
             out.name("UUID").value(accelerator.getUUID());
             out.name("deviceName").value(accelerator.getDeviceName());
-            out.name("isMIG").value(accelerator.isMIG());
+            out.name("isMIGSupported").value(accelerator.isMIGSupported());
+            out.name("isMIGPartition").value(accelerator.isMIGPartition());
         }
         // Add for other devices when added
 
@@ -41,7 +42,9 @@ public DeviceDetails read(JsonReader in) throws IOException {
         String hostName = null;
         String UUID = null;
         String deviceName = null;
+        String profile = null;
         boolean isMIG = false;
+        boolean isMIGPartition = false;
 
         in.beginObject();
         while (in.hasNext()) {
@@ -64,17 +67,23 @@ public DeviceDetails read(JsonReader in) throws IOException {
                 case "deviceName":
                     deviceName = in.nextString();
                     break;
-                case "isMIG":
+                case "isMIGSupported":
                     isMIG = in.nextBoolean();
                     break;
+                case "isMIGPartition":
+                    isMIGPartition = in.nextBoolean();
+                    break;
+                case "profile":
+                    profile = in.nextString();
+                    break;
                 default:
                     in.skipValue();
             }
         }
         in.endObject();
 
         if (type != null && type.equals(AnalyzerConstants.DeviceType.ACCELERATOR.name())) {
-            return (DeviceDetails) new AcceleratorDeviceData(modelName, hostName, UUID, deviceName, isMIG);
+            return (DeviceDetails) new AcceleratorDeviceData(modelName, hostName, UUID, deviceName, profile, isMIG, isMIGPartition);
         }
         // Add for other device types if implemented in future
 

diff --git a/src/main/java/com/autotune/analyzer/recommendations/engine/RecommendationEngine.java b/src/main/java/com/autotune/analyzer/recommendations/engine/RecommendationEngine.java
@@ -2227,7 +2227,7 @@ private void fetchContainerMetricsBasedOnDataSourceAndProfile(KruizeObject kruiz
                                                 metricObject.get(KruizeConstants.JSONKeys.HOSTNAME).getAsString(),
                                                 metricObject.get(KruizeConstants.JSONKeys.UUID).getAsString(),
                                                 metricObject.get(KruizeConstants.JSONKeys.DEVICE).getAsString(),
-                                                true);
+                                                null, true, false);
 
                                         JsonArray valuesArray = resultObject.getAsJsonArray(KruizeConstants.DataSourceConstants
                                                 .DataSourceQueryJSONKeys.VALUES);

diff --git a/src/main/java/com/autotune/analyzer/recommendations/utils/RecommendationUtils.java b/src/main/java/com/autotune/analyzer/recommendations/utils/RecommendationUtils.java
@@ -256,7 +256,7 @@ public static void markAcceleratorDeviceStatusToContainer(ContainerData containe
                                 metricObject.get(KruizeConstants.JSONKeys.HOSTNAME).getAsString(),
                                 metricObject.get(KruizeConstants.JSONKeys.UUID).getAsString(),
                                 metricObject.get(KruizeConstants.JSONKeys.DEVICE).getAsString(),
-                                isSupportedMig);
+                                null, isSupportedMig, false);
 
 
                         if (null == containerData.getContainerDeviceList()) {

diff --git a/...n/java/com/autotune/common/data/system/info/device/accelerator/AcceleratorDeviceData.java b/...n/java/com/autotune/common/data/system/info/device/accelerator/AcceleratorDeviceData.java
@@ -8,15 +8,25 @@ public class AcceleratorDeviceData implements AcceleratorDeviceDetails {
     private final String hostName;
     private final String UUID;
     private final String deviceName;
-    private boolean isMIG;
+    private final String profile;
+    private boolean isMIGSupported;
+    private boolean isMIGPartition;
 
-    public AcceleratorDeviceData (String modelName, String hostName, String UUID, String deviceName, boolean isMIG) {
+    public AcceleratorDeviceData (String modelName,
+                                  String hostName,
+                                  String UUID,
+                                  String deviceName,
+                                  String profile,
+                                  boolean isMIGSupported,
+                                  boolean isMIGPartition) {
+        this.profile = profile;
+        this.isMIGPartition = isMIGPartition;
         this.manufacturer = "NVIDIA";
         this.modelName = modelName;
         this.hostName = hostName;
         this.UUID = UUID;
         this.deviceName = deviceName;
-        this.isMIG = isMIG;
+        this.isMIGSupported = isMIGSupported;
     }
 
     @Override
@@ -44,12 +54,16 @@ public String getDeviceName() {
         return deviceName;
     }
 
-    public boolean isMIG() {
-        return isMIG;
+    public String getProfile() {
+        return profile;
     }
 
-    public void setMIG(boolean isMIG) {
-        this.isMIG = isMIG;
+    public boolean isMIGPartition() {
+        return isMIGPartition;
+    }
+
+    public boolean isMIGSupported() {
+        return isMIGSupported;
     }
 
     @Override