This repository was archived by the owner on Nov 15, 2024. It is now read-only.
first test #1
Open
first test #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivannizh
reviewed
Apr 1, 2024
ivannizh
left a comment
ivannizh
left a comment
There was a problem hiding this comment.
Привет! Хорошая работа! Осталось исправить некоторые моменты и работа будет принята.
main_test.go
Outdated
| require.NotEmpty(t, responseRecorder.Code) | ||
|
|
||
| status := responseRecorder.Code | ||
| require.Equal(t, status, http.StatusOK) |
main_test.go
Outdated
| handler := http.HandlerFunc(mainHandle) | ||
| handler.ServeHTTP(responseRecorder, req) | ||
|
|
||
| require.NotEmpty(t, responseRecorder.Code) |
There was a problem hiding this comment.
Нужно тело запроса проверить на пустоту, а код и так в 22 строчке проверяется
| handler.ServeHTTP(responseRecorder, req) | ||
|
|
||
| body := responseRecorder.Body.String() | ||
| assert.Equal(t, "wrong city value", body) |
main_test.go
Outdated
| require.NotEmpty(t, responseRecorder.Code) | ||
|
|
||
| status := responseRecorder.Code | ||
| require.Equal(t, status, http.StatusOK) |
main_test.go
Outdated
| require.Equal(t, status, http.StatusOK) | ||
|
|
||
| body := responseRecorder.Body.String() | ||
| assert.NotEqual(t, "wrong city value", body) |
There was a problem hiding this comment.
Достаточно странная проверка, но можно.
Странная в том плане, что мы и так в 51 строке проверяем, что там есть кафе и просто лишняя проверка
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.