This repository was archived by the owner on Nov 15, 2024. It is now read-only.
first itteration #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-musha
approved these changes
Apr 10, 2024
just-musha
left a comment
just-musha
left a comment
There was a problem hiding this comment.
Привет! Работа отличная! Есть весь функционал и все тесты с проверками. Небольшую правку в проверке id можно внести, если есть желание, но это не критично. Принято.
| // добавьте новую посылку в БД, убедитесь в отсутствии ошибки и наличии идентификатора | ||
| id, err := store.Add(parcel) | ||
| require.NoError(t, err) | ||
| assert.GreaterOrEqual(t, id, 0) |
There was a problem hiding this comment.
Тут нужно проверить что id заполнен, те не 0. Сейчас проверка допускает значение 0
| // добавьте новую посылку в БД, убедитесь в отсутствии ошибки и наличии идентификатора | ||
| id, err := store.Add(parcel) | ||
| require.NoError(t, err) | ||
| assert.GreaterOrEqual(t, id, 0) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.