Revert "Revert "Webpack migration for pages that use Stripe"" #36123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
requested review from
a team,
biyeun,
nospame and
dannyroberts
as code owners
orangejenny
requested review from
millerdev,
AmitPhulera,
gherceg and
jingcheng16
|
This is ready for review now and is also going to have another pass of QA. |
orangejenny
added
QA Passed
and removed
awaiting QA
jingcheng16
reviewed
Apr 2, 2025
| @@ -204,6 +211,7 @@ hqDefine('accounting/js/payment_method_handler', [ | |||
| if (self.savedCards().length > 0) { | |||
| self.selectedCardType('saved'); | |||
| } | |||
| self.showOrHideStripeUI(self.mustCreateNewCard()); | |||
There was a problem hiding this comment.
If we already subscribe to this observable, is this line still necessary?
There was a problem hiding this comment.
nvm! I saw you add a comment in a later commit
jingcheng16
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #36121, restoring #36073
I didn't realize there's a different UI for users who don't have any cards saved. This PR has a few additional commits to add support for that UI. The js is a bit finicky, as there are several knockout vars controlling the existence of the credit card inputs, and Stripe has to mount the UI whenever that area is made visible.
Safety Assurance
Safety story
Moderate risk due to affecting payments. Risk is limited to the updated pages.
Automated test coverage
Accounting has tests, but I don't think it has javascript coverage.
QA Plan
Using the same ticket as for the previous PR: https://dimagi.atlassian.net/browse/QA-7597
Rollback instructions
Labels & Review