Cleaned up mocha/base.html #36081
Merged
Cleaned up mocha/base.html #36081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
requested review from
millerdev,
AmitPhulera,
gherceg and
jingcheng16
jingcheng16
approved these changes
Mar 26, 2025
| <link href="{% static 'mocha/mocha.css' %}" type="text/css" rel="stylesheet"/> | ||
|
|
||
| <script> | ||
| window.USE_BOOTSTRAP5 = {{ use_bootstrap5|BOOL }}; | ||
| </script> | ||
|
|
||
| {% block stylesheets %}{% endblock %} |
There was a problem hiding this comment.
Why stylesheets is removed?
There was a problem hiding this comment.
There just aren't any tests using it. This isn't directly related to requirejs/webpack changes.
|
@jingcheng16 Good questions, responded. This is a safe PR so I'm going to merge, but let me know if you have additional questions or comments. |
|
@orangejenny Thank you for always being willing to provide detailed explanation with code examples!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
All js tests now use webpack. This PR removes the last bits of code used to set up requirejs tests or tests not using a bundler.
Safety Assurance
Safety story
It's all tests.
Automated test coverage
It's all tests.
QA Plan
no
Rollback instructions
Labels & Review