Upgrade kafka-python==2.1.4 #36049
Open
Upgrade kafka-python==2.1.4 #36049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
force-pushed
the
dm/upgrade-kafka-python
branch
3 times, most recently
from
3c31aa3 to
a6d1422
Compare
millerdev
requested review from
AmitPhulera,
a team,
dannyroberts and
calellowitz
as code owners
millerdev
force-pushed
the
dm/upgrade-kafka-python
branch
from
1d587c4 to
bfedf86
Compare
- Allow more accurate type introspection in IDEs. - Remove superfluous object base class.
Some things are broken. Specifically, SimpleClient has been removed in Kafka 2.x, and more refactoring is required for code that uses it.
The new technique has better performance because it polls at most twice rather than one or more times for each topic.
The kafka-python v2 async consumer seems to take more time to start.
Verify fix for regression in kafka-python>=2,<2.1.3
millerdev
force-pushed
the
dm/upgrade-kafka-python
branch
from
bfedf86 to
28eeb96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bump for Python 3.13 compatibility. Reviewed change log and recent issues (no concerns).
Some refactoring was needed to support v2. In general the refactored code should be more efficient.
Safety Assurance
Safety story
Major version update with some non-trivial refactoring required. Planning to test on staging.
Automated test coverage
Yes.
Rollback instructions