Remove SQLUserData when removing domain membership

[gherceg]

Product Description

Technical Summary

https://dimagi.atlassian.net/browse/SAAS-16810

Stumbled upon this issue when testing the dump and restore. We currently leave SQLUserData in an "orphaned" state when removing domain memberships, where a user still has SQLUserData associated with a domain they are no longer a part of.

This could lead to confusion if the user is re-added to this domain in the future as this SQLUserData will still be referenced/used. I think the more appropriate behavior is to cleanup any SQLUserData associated with a user and domain when removing that user from that domain.

Feature Flag

Safety Assurance

Safety story

This user data isn't useful once a user is no longer part of a domain.

Automated test coverage

Added tests to ensure deleting a domain membership cleans up SQLUserData as expected.

QA Plan

No

Rollback instructions

• This PR can be reverted after deploy with no further considerations

Labels & Review

• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[gherceg]

Realized I need to soft delete user data first as there is a workflow to restore a domain membership just after removing a user from a domain. So that blocks this PR from being merged for now. Created #36045 and once merged, can update this PR to soft delete instead.

[gherceg]

I don't love the direction this is going. I initially thought this would be a quick fix, but am realizing it is hard to make this change without impacting a lot of code. There is a unique constraint on user + domain on SQLUserData, hence needing to delete any soft deleted user data when adding a new domain membership.

I would say my confidence is in this change is low at the moment, and I would need to spend more time digging into this and probably run the change through QA to feel better about it.

[jingcheng16]

Looks good to me but can resonate your lack of confidence 😂 Recommend to do QA~~~ Though I don't know how can QA check the correct state of SQLUserData