Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaxMind secrets #6503

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Add MaxMind secrets #6503

merged 1 commit into from
Mar 27, 2025

Conversation

minhaminha
Copy link
Contributor

Jira Ticket

Environments Affected

Won't affect any environment until I update the secrets for each other them (separate API keys for each env, starting with Staging for testing)

Announce New Release
  • After merging, I will follow these instructions
    to announce a new commcare-cloud release.

@minhaminha minhaminha requested a review from esoergel March 26, 2025 21:34
@minhaminha
Copy link
Contributor Author

minhaminha commented Mar 26, 2025

Since I eventually will use commands to edit the secrets, I think that means this warrants a changelog PR based on the link in the description... will follow up shortly

Copy link
Contributor

@esoergel esoergel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to announce this in the changelog, as there's no action required by third parties

@minhaminha minhaminha merged commit f53f9ab into master Mar 27, 2025
2 checks passed
@minhaminha minhaminha deleted the ml/maxmind-secrets branch March 27, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants