Always return in error detection macros. (#2175)

diku-dk · Aug 27, 2024 · a9d8cee · a9d8cee
1 parent 0443389
commit a9d8cee
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -27,6 +27,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
   interface are now often better - although there are still cases
   where you end up with hashed names. (#2172)
 
+* In some cases, GPU failures would not be reported properly if a
+  previous failure was pending.
+
 ## [0.25.20]
 
 ### Added

diff --git a/rts/c/backends/cuda.h b/rts/c/backends/cuda.h
@@ -17,10 +17,10 @@ static char* get_failure_msg(int failure_idx, int64_t args[]);
     if (serror) {                               \
       if (!ctx->error) {                        \
         ctx->error = serror;                    \
-        return bad;                             \
       } else {                                  \
         free(serror);                           \
       }                                         \
+      return bad;                               \
     }                                           \
   }
 

diff --git a/rts/c/backends/hip.h b/rts/c/backends/hip.h
@@ -17,10 +17,10 @@ static char* get_failure_msg(int failure_idx, int64_t args[]);
     if (serror) {                               \
       if (!ctx->error) {                        \
         ctx->error = serror;                    \
-        return bad;                             \
       } else {                                  \
         free(serror);                           \
       }                                         \
+      return bad;                               \
     }                                           \
   }
 

diff --git a/rts/c/backends/opencl.h b/rts/c/backends/opencl.h
@@ -30,10 +30,10 @@ static char* get_failure_msg(int failure_idx, int64_t args[]);
     if (serror) {                               \
       if (!ctx->error) {                        \
         ctx->error = serror;                    \
-        return bad;                             \
       } else {                                  \
         free(serror);                           \
       }                                         \
+      return bad;                               \
     }                                           \
   }