Bring back CI on OpenCL and HIP. (#2108)

A bit hacky, since the system with the MI100 is not properly part of any Slurm queue yet.
diku-dk · Aug 18, 2024 · 40b0c45 · 40b0c45
1 parent 034f842
commit 40b0c45
Show file tree

Hide file tree

Showing 3 changed files with 84 additions and 84 deletions.
diff --git a/.github/actions/is-slurm/action.yml b/.github/actions/is-slurm/action.yml
@@ -14,7 +14,7 @@ runs:
       shell: bash
       run: |
         printf '#!/bin/bash
-        if ! srun --version &> /dev/null; then
+        if ! srun --version &> /dev/null || [ $(hostname) = hendrixfut02fl.unicph.domain ]; then
             echo "is-slurm=false"
         else
             echo "is-slurm=true"

diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -33,37 +33,37 @@ jobs:
         name: futhark-nightly-linux-x86_64.tar.xz
         path: result/futhark-nightly-linux-x86_64.tar.xz
 
-  # benchmark-MI100-opencl:
-  #   runs-on: MI100
-  #   needs: [build-linux-nix]
+  benchmark-MI100-opencl:
+    runs-on: MI100
+    needs: [build-linux-nix]
 
-  #   env:
-  #     TMPDIR: "/scratch"
-  #   steps:
-  #   - uses: actions/checkout@v3
-  #     with:
-  #       submodules: recursive
-  #       fetch-depth: 0
-  #   - uses: ./.github/actions/benchmark
-  #     with:
-  #       backend: opencl
-  #       system: MI100
+    env:
+      TMPDIR: "/scratch"
+    steps:
+    - uses: actions/checkout@v3
+      with:
+        submodules: recursive
+        fetch-depth: 0
+    - uses: ./.github/actions/benchmark
+      with:
+        backend: opencl
+        system: MI100
 
-  # benchmark-MI100-hip:
-  #   runs-on: MI100
-  #   needs: [build-linux-nix]
+  benchmark-MI100-hip:
+    runs-on: MI100
+    needs: [build-linux-nix]
 
-  #   env:
-  #     TMPDIR: "/scratch"
-  #   steps:
-  #   - uses: actions/checkout@v3
-  #     with:
-  #       submodules: recursive
-  #       fetch-depth: 0
-  #   - uses: ./.github/actions/benchmark
-  #     with:
-  #       backend: hip
-  #       system: MI100
+    env:
+      TMPDIR: "/scratch"
+    steps:
+    - uses: actions/checkout@v3
+      with:
+        submodules: recursive
+        fetch-depth: 0
+    - uses: ./.github/actions/benchmark
+      with:
+        backend: hip
+        system: MI100
 
   benchmark-A100:
     runs-on: hendrix

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -388,46 +388,46 @@ jobs:
         pip install 'numpy<2.0.0' pyopencl jsonschema
         futhark test tests -c --no-terminal --backend=pyopencl --exclude=compiled --cache-extension=cache --pass-option=--build-option=-O0 --runner=tools/oclgrindrunner.sh
 
-  # test-opencl:
-  #   runs-on: opencl
-  #   needs: [build-linux-nix]
-  #   if: github.repository == 'diku-dk/futhark'
-  #   steps:
-  #   - uses: actions/checkout@v3
+  test-opencl:
+    runs-on: hendrix
+    needs: [build-linux-nix]
+    if: github.repository == 'diku-dk/futhark'
+    steps:
+    - uses: actions/checkout@v3
 
-  #   - uses: ./.github/actions/futhark-slurm
-  #     with:
-  #       script: |
-  #         set -e
-  #         python -m venv virtualenv
-  #         source virtualenv/bin/activate
-  #         pip install jsonschema
-  #         module unload cuda
-  #         module load cuda/11.8
-  #         futhark test tests \
-  #           --backend=opencl \
-  #           --cache-extension=cache
-  #         FUTHARK_BACKEND=opencl make -C tests_lib/c -j
-  #       slurm-options: -p gpu --time=0-01:00:00 --gres=gpu:1 --job-name=fut-opencl-test --exclude=hendrixgpu05fl,hendrixgpu06fl
-
-  # test-pyopencl:
-  #   runs-on: opencl
-  #   needs: [build-linux-nix]
-  #   if: github.repository == 'diku-dk/futhark'
-  #   steps:
-  #   - uses: actions/checkout@v3
+    - uses: ./.github/actions/futhark-slurm
+      with:
+        script: |
+          set -e
+          python -m venv virtualenv
+          source virtualenv/bin/activate
+          pip install jsonschema
+          module unload cuda
+          module load cuda/11.8
+          futhark test tests \
+            --backend=opencl \
+            --cache-extension=cache
+          FUTHARK_BACKEND=opencl make -C tests_lib/c -j
+        slurm-options: -p gpu --time=0-01:00:00 --gres=gpu:1 --job-name=fut-opencl-test --exclude=hendrixgpu05fl,hendrixgpu06fl
 
-  #   - uses: ./.github/actions/futhark-slurm
-  #     with:
-  #       script: |
-  #         set -e
-  #         python -m venv virtualenv
-  #         source virtualenv/bin/activate
-  #         pip install numpy pyopencl jsonschema
-  #         module unload cuda
-  #         module load cuda/11.8
-  #         futhark test tests --no-terminal --backend=pyopencl
-  #       slurm-options: -p gpu --time=0-01:00:00 --gres=gpu:1 --job-name=fut-pyopencl-test --exclude=hendrixgpu05fl,hendrixgpu06fl
+  test-pyopencl:
+    runs-on: hendrix
+    needs: [build-linux-nix]
+    if: github.repository == 'diku-dk/futhark'
+    steps:
+    - uses: actions/checkout@v3
+
+    - uses: ./.github/actions/futhark-slurm
+      with:
+        script: |
+          set -e
+          python -m venv virtualenv
+          source virtualenv/bin/activate
+          pip install numpy pyopencl jsonschema
+          module unload cuda
+          module load cuda/11.8
+          futhark test tests --no-terminal --backend=pyopencl
+        slurm-options: -p gpu --time=0-01:00:00 --gres=gpu:1 --job-name=fut-pyopencl-test --exclude=hendrixgpu05fl,hendrixgpu06fl
 
   test-cuda:
     runs-on: cuda
@@ -453,25 +453,25 @@ jobs:
           FUTHARK_BACKEND=cuda make -C tests_lib/c -j
         slurm-options: -p gpu --time=0-01:00:00 --gres=gpu:a100:1 --job-name=fut-cuda-test
 
-  # test-hip:
-  #   runs-on: MI100
-  #   needs: [build-linux-nix]
-  #   if: github.repository == 'diku-dk/futhark'
-  #   steps:
-  #   - uses: actions/checkout@v3
+  test-hip:
+    runs-on: MI100
+    needs: [build-linux-nix]
+    if: github.repository == 'diku-dk/futhark'
+    steps:
+    - uses: actions/checkout@v3
 
-  #   - run: |
-  #       python -m venv virtualenv
-  #       source virtualenv/bin/activate
-  #       pip install jsonschema
+    - run: |
+        python -m venv virtualenv
+        source virtualenv/bin/activate
+        pip install jsonschema
 
-  #   - uses: ./.github/actions/futhark-slurm
-  #     with:
-  #       script: |
-  #         set -e
-  #         futhark test tests --no-terminal --backend=hip --concurrency=8
-  #         source virtualenv/bin/activate
-  #         FUTHARK_BACKEND=hip make -C tests_lib/c -j
+    - uses: ./.github/actions/futhark-slurm
+      with:
+        script: |
+          set -e
+          futhark test tests --no-terminal --backend=hip --concurrency=8
+          source virtualenv/bin/activate
+          FUTHARK_BACKEND=hip make -C tests_lib/c -j
 
   test-wasm:
     runs-on: ubuntu-22.04