Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint-plugin-sonarjs): upgrade v3 & fix rules #1516

Merged
merged 8 commits into from
Dec 9, 2024
Merged

chore(eslint-plugin-sonarjs): upgrade v3 & fix rules #1516

merged 8 commits into from
Dec 9, 2024

Conversation

chohner
Copy link
Member

@chohner chohner commented Dec 3, 2024

  • moves some sonarjs/ rules to react/
  • fixes some new rules
  • removes some unused old rules

Spencer6497
Spencer6497 approved these changes Dec 9, 2024
View reviewed changes
aaschlote
aaschlote approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@aaschlote aaschlote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sonar cloud team replied my questions in this issue, I believe this changes are correct.

LGTM!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chohner chohner merged commit dd331bf into main Dec 9, 2024
21 checks passed
@chohner chohner deleted the upgradeEslintSonarjs branch December 9, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaschlote aaschlote aaschlote approved these changes

@Spencer6497 Spencer6497 Spencer6497 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chohner @aaschlote @Spencer6497