Fix fluggastrechte pdf problems

app/domains/fluggastrechte/services/pdf/sections/__test__/createBankInformation.test.ts

@@ -45,6 +45,46 @@ describe("createBankInformation", () => {
     );
   });
 
+  it("should default to vorname and nachname if account holder is empty string", () => {
+    const mockStruct = mockPdfKitDocumentStructure();
+    const mockDoc = mockPdfKitDocument(mockStruct);
+    const userDataNoAccountHolder = {
+      ...userDataMock,
+      kontoinhaber: "",
+      vorname: "Max",
+      nachname: "Mustermann",
+    };
+
+    createBankInformation(mockDoc, mockStruct, userDataNoAccountHolder);
+
+    expect(mockDoc.struct).toHaveBeenCalledWith("P", {}, expect.any(Function));
+    expect(mockDoc.text).toHaveBeenCalledWith(
+      "Kontoinhaber: Mustermann, Max | IBAN: DE68500123456789000000",
+      expect.anything(),
+      expect.anything(),
+    );
+  });
+
+  it("should default to vorname and nachname if account holder has empty space string", () => {
+    const mockStruct = mockPdfKitDocumentStructure();
+    const mockDoc = mockPdfKitDocument(mockStruct);
+    const userDataNoAccountHolder = {
+      ...userDataMock,
+      kontoinhaber: " ",
+      vorname: "Max",
+      nachname: "Mustermann",
+    };
+
+    createBankInformation(mockDoc, mockStruct, userDataNoAccountHolder);
+
+    expect(mockDoc.struct).toHaveBeenCalledWith("P", {}, expect.any(Function));
+    expect(mockDoc.text).toHaveBeenCalledWith(
+      "Kontoinhaber: Mustermann, Max | IBAN: DE68500123456789000000",
+      expect.anything(),
+      expect.anything(),
+    );
+  });
+
   it("should not add bank information if IBAN is missing", () => {
     const mockStruct = mockPdfKitDocumentStructure();
     const mockDoc = mockPdfKitDocument(mockStruct);
@@ -95,4 +135,32 @@ describe("createBankInformation", () => {
       expect.anything(),
     );
   });
+
+  it("should not create document given undefined iban", () => {
+    const mockStruct = mockPdfKitDocumentStructure();
+    const mockDoc = mockPdfKitDocument(mockStruct);
+
+    const userDataWithoutIban = {
+      ...userDataMock,
+      iban: undefined,
+    };
+
+    createBankInformation(mockDoc, mockStruct, userDataWithoutIban);
+
+    expect(mockDoc.text).not.toBeCalled();
+  });
+
+  it("should not create document given an empty iban", () => {
+    const mockStruct = mockPdfKitDocumentStructure();
+    const mockDoc = mockPdfKitDocument(mockStruct);
+
+    const userDataWithoutIban = {
+      ...userDataMock,
+      iban: "",
+    };
+
+    createBankInformation(mockDoc, mockStruct, userDataWithoutIban);
+
+    expect(mockDoc.text).not.toBeCalled();
+  });
 });

app/domains/fluggastrechte/services/pdf/sections/createBankInformation.ts

@@ -9,13 +9,15 @@ import {
 export const createBankInformation = (
   doc: typeof PDFDocument,
   footerSect: PDFKit.PDFStructureElement,
-  userData: FluggastrechtContext,
+  { kontoinhaber, vorname, nachname, iban }: FluggastrechtContext,
 ) => {
   const bankAccountHolder =
-    userData.kontoinhaber ?? `${userData.nachname}, ${userData.vorname}`;
+    typeof kontoinhaber !== "undefined" && kontoinhaber.trim().length > 0
+      ? kontoinhaber
+      : `${nachname}, ${vorname}`;
 
-  if (userData?.iban) {
-    const bankInfo = `Kontoinhaber: ${bankAccountHolder} | IBAN: ${userData.iban}`;
+  if (iban) {
+    const bankInfo = `Kontoinhaber: ${bankAccountHolder} | IBAN: ${iban}`;
     footerSect.add(
       doc.struct("P", {}, () => {
         doc