fix(repair broken cached-checkout-install step) #1454
Conversation
| @@ -14,16 +14,14 @@ runs: | |||
| env: | |||
| cache-name: cache-node-modules | |||
| with: | |||
| path: ~/.npm | |||
| path: ./node_modules | |||
There was a problem hiding this comment.
fyi https://github.com/actions/cache/blob/main/examples.md#node---npm
Note It is not recommended to cache node_modules, as it can break across Node versions and won't work with npm ci
There was a problem hiding this comment.
saw that; two thoughts:
- to avoid this breaking across Node versions, we could hash the node version and add it to the key
- npm ci only runs on a cache miss, so node_modules won't exist in that case
There was a problem hiding this comment.
Thank you for the explanation. I checked the build time for all previous pull requests and didn't see any significant improvement. Am I missing something?
There was a problem hiding this comment.
there's a slight speedup for pull requests, but PRs only trigger the first 3 steps of the CI flow; every other step also uses cached-checkout-install, so full deployments should be faster by a few minutes, maybe 3 or so
|
This PR fixes a bug where
npm ciwas being called every timecached-checkout-installwas being called, regardless ifnode_moduleswas found in the cache or not. This should reduce our pipeline times by a considerable amount :)