feat(pdf-service): add metadata to BerH and PKH pdfs #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chohner
approved these changes
Nov 19, 2024
Comment on lines
+30
to
+44
| it("should add metadata to the PDF document", () => { | ||
| const doc = mockPdfLibDocument(); | ||
|
|
||
| addMetadataToPdf(doc, metadata); | ||
|
|
||
| expect(doc.setAuthor).toHaveBeenCalledWith(metadata.AUTHOR); | ||
| expect(doc.setCreator).toHaveBeenCalledWith(metadata.CREATOR); | ||
| expect(doc.setKeywords).toHaveBeenCalledWith(metadata.KEYWORDS); | ||
| expect(doc.setLanguage).toHaveBeenCalledWith(metadata.LANGUAGE); | ||
| expect(doc.setProducer).toHaveBeenCalledWith(metadata.PRODUCER); | ||
| expect(doc.setSubject).toHaveBeenCalledWith(metadata.SUBJECT); | ||
| expect(doc.setTitle).toHaveBeenCalledWith(metadata.TITLE); | ||
| expect(doc.setCreationDate).toHaveBeenCalled(); | ||
| expect(doc.setModificationDate).toHaveBeenCalled(); | ||
| }); |
There was a problem hiding this comment.
Imo this test can be removed. we shouldn't care about the implementation details of addMetadataToPdf - expecting the metadata to end up in the pdf should be more than enough
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata is added to the filled PDF forms. When pages are appended to the existing PDF form (which is the case for both BerH and PKH), the metadata from the main PDF (to which the other one will be appended to) is taken over. So adding metadata to the attachmens and checklists is redundant.