Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_failover_replication_time_lag configuration with constraints #938

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Add max_failover_replication_time_lag configuration with constraints #938

merged 5 commits into from
Oct 29, 2024

Conversation

vsharma6855
Copy link
Contributor

@vsharma6855 vsharma6855 commented Oct 28, 2024 •
edited
Loading

  • Set description for max_failover_replication_time_lag
  • Define value constraints (min: 10, max: 9223372036854776000)
  • Provide default (60) and example (50) values

v.sharma and others added 3 commits October 28, 2024 19:38
Add max_failover_replication_time_lag configuration with constraints
cf9133d 
- Set description for `max_failover_replication_time_lag`
- Define value constraints (min: 10, max: 9223372036854776000)
- Provide default (60) and example (4) values
@vsharma6855
Merge branch 'main' into feature/max_failover_replication_time_lag
6a35dd3
example should be within the range
20f7ca6
loosla
loosla previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@loosla loosla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👍
It would be great if this new field - max_failover_replication_time_lag - could be added to godo, doctl, and Terraform.

It seems that synchronous_replication and stat_monitor_enable are also absent from godo, doctl, and Terraform.

@vsharma6855 @andrewsomething
Update specification/resources/databases/models/advanced_config/postg…
ce173e8 
…res_advanced_config.yml

Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
@vsharma6855
Copy link
Contributor Author

It looks good to me 👍 It would be great if this new field - max_failover_replication_time_lag - could be added to godo, doctl, and Terraform.

It seems that synchronous_replication and stat_monitor_enable are also absent from godo, doctl, and Terraform.

Yes, we will be adding PR for that.

loosla
loosla approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@loosla loosla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vsharma6855
Copy link
Contributor Author

Here is the card for above recommendations:
https://do-internal.atlassian.net/browse/DBAAS-5519

@andrewsomething andrewsomething merged commit cec05e9 into digitalocean:main Oct 29, 2024
6 checks passed
@digitalocean-engineering digitalocean-engineering mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosla loosla loosla approved these changes

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsharma6855 @andrewsomething @loosla