-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update configuration subcommand to databases #1455
Conversation
Signed-off-by: titanventura <[email protected]>
Signed-off-by: titanventura <[email protected]>
Signed-off-by: titanventura <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@titanventura Thanks for this great contribution!
Would you be able to write integration tests for these changes to help ensure future changes do not break the intended functionality?
The integration/
directory has many examples. Let me know if you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a few additional commit resolving the conflicts, adding tests, and addressing my PR comments. Thanks again for this great contribution!
fixes #1430