Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update configuration subcommand to databases #1455

Merged
merged 9 commits into from
Nov 17, 2023

Conversation

titanventura
Copy link
Contributor

fixes #1430

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@titanventura Thanks for this great contribution!

Would you be able to write integration tests for these changes to help ensure future changes do not break the intended functionality?

The integration/ directory has many examples. Let me know if you have any questions.

commands/databases.go Outdated Show resolved Hide resolved
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a few additional commit resolving the conflicts, adding tests, and addressing my PR comments. Thanks again for this great contribution!

@andrewsomething andrewsomething merged commit 4977364 into digitalocean:main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants