Fix jsbn browser check #1106
Open
Fix jsbn browser check #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous versions of NodeJS/Bun/Deno didn't have 'navigator' defined, while latest one do have it, which forces am2 algorithm with 26 dbits, which is awfully slow, at least in NodeJS v22 (compared to am3 with 28 bits)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1081
Previous versions of NodeJS/Bun/Deno didn't have 'navigator' defined, while latest one do have it, which forces am2 algorithm with 26 dbits, which is awfully slow (~20x), at least in NodeJS v22 (compared to am3 with 28 dbits)