Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remote-signing]: allow p7 DigestInfo extraction and signature insertion into p7 structure #1038

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rohhamh
Copy link

@rohhamh rohhamh commented Jun 16, 2023

I think it makes for a nice addition to allow digestInfo to be extracted and signed off-platform when the private key isn't available and the private-key owner's platform doesn't support CMS (iOS as an example).

Basically the code duplicates some of the available functions and methods and omits the signing parts of it.
There are also two new methods which allow for addition of signature and extraction of digestInfo object

However, I'm not sure if the namings are accurate or correct according to common cryptographic terms or if the code follows and matches the previously available patterns and conventions of the code.

rohhamh and others added 4 commits May 31, 2023 00:29
…ifying key, used to generate the asn1 and der formats to enable helped cms creation on PKCS7-disabled platforms (e.g. iOS).

The actual digest that needs to be signed will be generated and extractable, and allows simple privateEncrypted messages (signatures) to be added to the structure and the final PEM be generated.
Add sample usage for added methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant