Skip to content

Conversation

@davidlehn
Copy link
Member

  • Use @digitalbazaar/eslint-config@7.
  • Remove unneeded peer deps.
  • Add globals.

@davidlehn davidlehn requested a review from BigBlueHat October 24, 2025 21:19
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2025

Deploying canivc with  Cloudflare Pages  Cloudflare Pages

Latest commit: 615a96d
Status: ✅  Deploy successful!
Preview URL: https://b02d463b.canivc.pages.dev
Branch Preview URL: https://update-dependencies.canivc.pages.dev

View logs

- Use `@digitalbazaar/eslint-config@7`.
- Remove unneeded peer deps.
- Add `globals`.
@BigBlueHat
Copy link
Collaborator

@davidlehn looks like the globals dependency was coming in via @digitalbazaar/eslint-config and the explicit inclusion here wasn't needed. I removed it from this package.json and did an npm ci and linting ran the same as before removing it. So...am I missing something? or is it OK to remove this dependency (as I've done in 615a96d)?

@davidlehn
Copy link
Member Author

eslint.config.js is using globals directly, so seemed appropriate to have it as a dependency. In this case, I'm pretty sure it will keep being an indirect dependency, but general best practice is to depend on what you use. npm-check flagged it which is why it was added.

There may be a better way to set thing up to avoid the issue in general. A special clause for those asset files seemed like a good enough approach at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants