Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.0 #164

Open
wants to merge 170 commits into
base: main
Choose a base branch
from
Open

v2.1.0 #164

wants to merge 170 commits into from

Conversation

maskatsum
Copy link
Contributor

No description provided.

maskatsum and others added 30 commits August 1, 2024 00:10
レビューが必要なほどの修正ではないので、マージします
jestで@を使ったimportがあっても動くように修正
ジオコーディング全体に関する改善
@maskatsum maskatsum marked this pull request as ready for review October 29, 2024 10:09
@maskatsum
Copy link
Contributor Author

maskatsum commented Oct 31, 2024

Coverage Summary

Lines Statements Branches Functions
Coverage: 54%
54.39% (1418/2607) 48.02% (401/835) 27.9% (96/344)

JUnit

Tests Skipped Failures Errors Time
143 7 💤 0 ❌ 0 🔥 9.36s ⏱️
Coverage Details (54%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files54.3948.0227.954.02 
config100100100100 
   constant-values.ts100100100100 
   data-field.ts100100100100 
   db-table-name.ts100100100100 
domain/models19.646.256.6619.64 
   abr-abort-controller.ts4.87004.8754–125, 130–138
   common-di-container.ts66.66100066.6630
   env-provider.ts58.33252558.3334–45
domain/services62.9647.364060.39 
   crc32-lib.ts77.7707571.4228–32
   make-dir-if-not-exists.ts50004029–33
   parse-filename.ts9687.510095.8377
   reg-exp-ex.ts10066.6610010035
   remove-files.ts27.770023.5232–54
   table-key-provider.ts34.480034.4833–39, 45–56, 63–69, 77–83, 94–103, 111–120
domain/services/logger26.660026.66 
   debug-logger.ts26.660026.6632–70
domain/services/package100100100100 
   parse-package-json.ts100100100100 
domain/services/thread9.81009.87 
   shared-memory.ts3010003027–31, 35–36
   worker-thread-pool-task-info.ts7.14007.1432–89
   worker-thread-pool.ts7.8900835–182
   worker-thread.ts10.20010.231–128, 137–139
domain/services/transformations89.5885.7166.6689.58 
   comment-filter-transform.ts89.5885.7166.6689.5832, 107–108, 112–113
domain/types86.7644.445087.69 
   pref-lg-code.ts85.9328.5733.3386.8887–96
   search-target.ts100100100100 
domain/types/download100100100100 
   file-group.ts100100100100 
domain/types/geocode53.84033.3353.84 
   match-level.ts53.84033.3353.8434, 37–57
domain/types/messages83.0571.425082.75 
   abrg-error.ts63.631005063.6344–47
   abrg-message.ts86.66604086.66145, 154–161
   get-system-locale.ts100100100100 
interface4.6004.76 
   http-request-adapter.ts4.6004.7631–48, 60–61, 69–73, 81–85, 94–98, 115–473
interface/database180018 
   geocode-db-controller.ts18001844–173
interface/database/sqlite329.260029.26 
   better-sqlite3-wrap.ts28002832–109
   sqlite3-util.ts31.250031.2530–54
interface/database/sqlite3/geocode11.590011.65 
   common-db-geocode-sqlite3.ts7.05007.160–1140
   parcel-db-geocode-sqlite3.ts36.360036.3639–75
   rsdt-blk-db-geocode-sqlite3.ts30.760030.7638–78
   rsdt-dsp-db-geocode-sqlite3.ts30.760030.7637–89
interface/format74.2872.1610073.91 
   csv-transform.ts74.2872.1610073.9155–61, 83, 140–143, 179–197
usecases/geocode14.660014.86 
   abr-geocoder.ts160016.3237–105, 114–141
   fake-worker-thread-pool.ts12001233–89
usecases/geocode/models70.3164.2861.970.15 
   abr-geocoder-di-container.ts33.330033.3341–54
   oaza-cho-trie-finder.ts58.62033.3358.6219, 24, 90–134
   query-set.ts63.155062.563.1550, 60–72
   query.ts82.5269.3887.582.35255–257, 331, 350–361, 386, 420–431
usecases/geocode/models/trie80.2970.0583.3379.95 
   char-node.ts82.2272.059081.8452–91, 103, 144, 149, 205–206, 345, 376, 402, 420, 445–449, 471, 473, 487–513, 548, 569–570, 614, 619, 649, 658
   trie-finder.ts7364.766.667376–85, 98–103, 165, 198–199, 210, 234–245, 262, 267, 276–280, 317, 331
usecases/geocode/services82.3379.0310081.71 
   get-levenshtein-distance-ratio.ts100100100100 
   insert-space-before-room-or-facility.ts94.0287.1710093.8431, 47–49
   is-number.ts9085.7110088.8833
   jis-kanji.ts75.7170.5810075.36441, 467, 476–482, 502–508, 522–528
   kan2num.ts74.2865.7810073.91107, 163–164, 176, 197, 212–236, 254, 260, 278–283, 287–288, 305–310, 321
   to-hankaku-alpha-num.ts9085.7110089.4794, 106
   to-hiragana.ts90.99010090.47236, 253
   trim-dash-and-space.ts100100100100 
usecases/geocode/steps36.3621.641.1736.57 
   normalize-transform.ts64.9635.2971.4264.9664, 117, 131, 189–193, 210–217, 227–328, 344–345, 374–375, 379, 382, 385–386, 388–389
   parcel-transform.ts6.28006.3541–388
   pref-transform.ts82.757510082.7550–51, 66–67, 73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants