Repository navigation
upgrade: rebase patch series onto v24.22.0 - #14
Open
gmaclennan wants to merge 4 commits into
Open
gmaclennan wants to merge 4 commits into
gmaclennan wants to merge 4 commits into
Conversation
Skip test-crypto-provider-cache-snapshot (builds a snapshot in a child node) and, on iOS, test-internal-webidl-buffer-source (its new --experimental-wasm-rab-integration flag does not exist in lite-mode V8). Guard the new spawning subtest in test-fs-glob, and expect ENOTEMPTY from rmSync on mobile, where libc++'s std::filesystem::remove_all reports it as on macOS.
Since 37.2.12 the full device suite's Android shards are killed by a runner shutdown signal about ten minutes in, on recipe (run 38721027963) as well as on the v24.22.0 upgrade. 37.1.11 (build 15917651) is the last version that completed the suite.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-bases the patch series onto upstream v24.22.0. The recipe reconstructs from a fresh upstream clone at the tree recorded in
expected-tree.txt.Conflicts
src/node.cc: see "Upstream changes absorbed" below.README.md: the fork README replaces the upstream remainder, so it resolves to ours.author-ready-conflicts.ymlandcontributor-guidance.yml, are deleted and assigned to that patch infiles.map. Upstream deletedcommit-lint-problem-matcher.jsonitself, so itsfiles.mapline is gone.No new static library targets, so the iOS link list is unchanged.
Upstream changes absorbed
v24.22.0 wraps
--experimental-wasm-jspiin#if V8_ENABLE_WEBASSEMBLY, and itscommon.gypinow sets that define on node's own targets whenv8_enable_webassembly == 1. Our iOS-only guard is therefore redundant:ios_framework_prepare.shalways passes--v8-lite-mode,configure.pymaps that tov8_enable_webassembly=0, so iOS drops the flag while Android keeps WebAssembly and the flag. The hunk is gone fromsrc-mobile-platform-guards-in-node.cc-node_internals.patch, along with the header paragraph that explained it. The iOS boot smoke confirms this chain.Test changes
Entries below were inferred from reading the test sources unless marked as seen on the full device suite.
Clear-cut skips
Spawns a child node process (both platforms):
test-benchmark-compare,test-common-wpt-script-modifier,test-debugger-no-inspect-brk,test-fs-glob-no-follow-symlink-globstar,test-module-unreadable-package-json,test-permission-openssl-store,test-runner-mock-dual-package,test-webcrypto-prototype-pollution, andtest-crypto-provider-cache-snapshot(builds a snapshot in a child; seen failing on Android). The new spawning subtest in the existingtest-fs-glob.mjsgets an anchoredskip(seen failing on Android) rather than skipping the file's ~100 other subtests.Runs under
--permissionwithout--allow-fs-write, so the verdict write is denied (both platforms):test-permission-fs-filehandle-sync,test-permission-linked-binding,test-permission-linked-binding-drop.iOS lite-mode V8 lacks the flag:
test-internal-webidl-buffer-sourcegained--experimental-wasm-rab-integrationin its// Flags:header and fails withbad option(seen on iOS).Judgement calls
test-fs-realpath-stale-stat-valuesandtest-fs-realpath-async-stale-stat-valuesexecmkfifo, not node. Skipped on both platforms, following the existingmkfifotests. These are the entries to question first.test-fs-rmSync-special-char-additional-error(new; seen failing on both platforms) expectsEACCESexcept on macOS, where it expectsENOTEMPTY. rmSync usesstd::filesystem::remove_all, and both mobile platforms link libc++ as macOS does, so they reportENOTEMPTYtoo. Fixed with an anchored guard rather than a skip, so the rest of the test still runs.test-debugger-probe-startup-disconnectandtest-debugger-wait-for-debuggerare left to run on iOS: they drive a mocked inspector client, not a child process. Android'stest-debugger-probe-*glob already covers the former.Failures that may indicate a mobile issue
None outstanding.
test-worker-internal-modulesgave no verdict on iOS in the first run, which was worth a look becausesrc/node_worker.ccchanged worker isolate setup and teardown in this release. It passed on every iOS shard in the second run, so it is treated as a flake and not skipped. Watch for it recurring.Also guarded:
test-sqlite-backup.mjsgained a subtest that spawns node (spawnPromisified(process.execPath)), found by the triage script in #15 rather than by a device run, because the Android shards never reached it.CI: Android emulator pinned
The Android full-suite shards were killed by a runner shutdown signal about ten minutes in, on every shard in both runs here and also on unchanged
recipe(run 38721027963). Every one ran Android emulator 37.2.12; the last completed Android suite (4 September) ran 37.1.11. Theci:commit pinsemulator-build: 15917651(37.1.11) in all three emulator workflows, and with it all four Android shards finished in about 15 minutes. It is independent of the upgrade and can be split into its own PR if preferred.Verification
OKon the recorded hash.audit-test-edits.shpasses.upstream-base.Manual steps
None outstanding:
upstream-basealready points at v24.22.0.