README requirement #67
Merged
+22
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tieqiong Let's make a PR that fixes the flake8 errors separately. I will merge that, and then we can only merge these PRs that are fixing functional issues when everything passes. Please can you do that? Thanks. |
|
Also, this seems to be failing tests still. |
|
@sbillinge Yes I'll try to fix the flake 8 issues. I think the CI should pass now, it's failing because it was checked before Andrew's environment.yml got merged. |
|
the pre-co mmit.yml nees to be be removed from .github/workflows (now handled by pre-commit.ci). Also, I think we will hvae to merge main into the branch for these changes to take effect on this PR. Please could you try that? Then we will see if it is passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy paste old readme requirements part