[rewrite] add CodeCleanup
#2812
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,6 @@ on: | |
| push: | ||
| branches: [main, release] | ||
| workflow_dispatch: | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
@@ -19,34 +18,35 @@ jobs: | |
| buildcacheuser: ${{ secrets.BUILDCACHE_USER }} | ||
| buildcachepass: ${{ secrets.BUILDCACHE_PASS }} | ||
| steps: | ||
| - name: Checkout Code 📥 | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 21 | ||
| - name: Setup Gradle 🐘 | ||
| uses: gradle/actions/setup-gradle@v5 | ||
| - name: Spotless ✨ | ||
| run: ./gradlew clean spotlessCheck | ||
| - name: Error Prone 🚧 | ||
| run: ./gradlew clean assemble | ||
| - name: Test Classes ⚙️ | ||
| run: ./gradlew clean testClasses | ||
| - name: Rewrite ♻️ | ||
| run: ./gradlew clean rewriteDryRun | ||
|
Contributor
Author
There was a problem hiding this comment. try with |
||
| build: | ||
| name: Build 🏗️ | ||
| needs: sanity-check | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| kind: [maven, gradle] | ||
| jre: [17, 21, 24] # test on the latest Java version once Gradle & Maven support it. | ||
| os: [ubuntu-latest, windows-latest] | ||
| include: | ||
| - kind: npm # npm on linux only (crazy slow on windows). | ||
| jre: 17 | ||
| os: ubuntu-latest | ||
| - kind: shfmt | ||
|
|
@@ -58,66 +58,64 @@ jobs: | |
| os: ubuntu-latest | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Checkout Code 📥 | ||
| uses: actions/checkout@v6 | ||
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: temurin | ||
| java-version: ${{ matrix.jre }} | ||
| - name: Setup Gradle 🐘 | ||
| uses: gradle/actions/setup-gradle@v5 | ||
| - name: Build Maven 🪶 | ||
| if: matrix.kind == 'maven' | ||
|
Contributor
Author
There was a problem hiding this comment.
|
||
| run: ./gradlew :plugin-maven:build -x spotlessCheck | ||
| - name: Build Gradle 🐘 | ||
| if: matrix.kind == 'gradle' | ||
| run: ./gradlew build -PSPOTLESS_EXCLUDE_MAVEN=true -x spotlessCheck | ||
| - name: Test npm 📊 | ||
| if: matrix.kind == 'npm' | ||
| run: ./gradlew testNpm | ||
| - name: Setup Go | ||
| if: matrix.kind == 'shfmt' | ||
| uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: stable | ||
| - name: Install shfmt 📥 | ||
| if: matrix.kind == 'shfmt' | ||
| run: go install mvdan.cc/sh/v3/cmd/shfmt@${{ matrix.shfmt-version }} | ||
| - name: Test shfmt 📊 | ||
| if: matrix.kind == 'shfmt' | ||
| run: ./gradlew testShfmt | ||
| - name: Test IDEA 📊 | ||
| if: matrix.kind == 'idea' | ||
| run: | | ||
| download_link=$(curl https://data.services.jetbrains.com/products/releases\?code\=IIC\&latest\=true\&type\=release | jq -r '.IIC[0].downloads.linux.link') | ||
| curl --location $download_link -o idea.tar.gz | ||
| tar -xf idea.tar.gz | ||
| cd idea-IC* | ||
| export PATH=${PATH}:$(pwd)/bin | ||
| cd .. | ||
| ./gradlew testIdea | ||
| - name: Junit Report 📋 | ||
| uses: mikepenz/action-junit-report@v6 | ||
| if: always() # always run even if the previous step fails. | ||
| with: | ||
| check_name: JUnit ${{ matrix.kind }} ${{ matrix.jre }} ${{ matrix.os }} | ||
| report_paths: '*/build/test-results/*/TEST-*.xml' | ||
| check_retries: true | ||
| complete: # this check is required in branch protection rules. | ||
| name: Complete ✅ | ||
| needs: | ||
| - sanity-check | ||
| - build | ||
| runs-on: ubuntu-latest | ||
| if: always() | ||
| steps: | ||
| - name: Check 🦉 | ||
| run: | | ||
| results=$(tr -d '\n' <<< '${{ toJSON(needs.*.result) }}') | ||
| if ! grep -q -v -E '(failure|cancelled)' <<< $results; then | ||
| echo ❌ One or more required jobs failed. | ||
| exit 1 | ||
| fi | ||
| echo ✅ All required jobs completed successfully. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is came into live as one job:
as its one dedicated goal why not run it also in dedicated job?