Conversation
Member
|
In the interest of long-term maintainability, what do you think about moving this change out of Overtype and into our own code? Seems like we're not fighting overtype's defaults here, just the tag's defaults. |
Collaborator
Author
|
It's up to you. The code that this PR changes in "overtype" is in a style block that we added to overtype. So this isn't adding any additional friction, just piggy backing on what's already there. Plus, the bug is in overtype, so might make sense that the fix be in overtype. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37
Overtype bug.
Code blocks wrap instead of scroll horizontally.
Not sure if the way we fixed it is the way it should be fixed. Should probably not use a
pretag at all. But telling a pre to wrap is easier.