Skip to content

docs: retire the merged-stack instructions from the Workspaces guide - #658

Closed
dormouse-bot wants to merge 2 commits into
mainfrom
fix/workspaces-guide-poststack-34964871547
Closed

dormouse-bot wants to merge 2 commits into
mainfrom
fix/workspaces-guide-poststack-34964871547

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

TESTING_AND_MODIFICATION_GUIDE.md opens by telling an agent to work on the stack's tip branch, merge changes forward through the later branches, and land the PRs in order with merge commits. All eleven of those PRs (#614#623, #630) merged on 2026-09-15, so an agent following section 1 or 1a today looks for branches and worktrees that no longer exist, and a Workspaces change made on main reads as a mistake against instructions that assume the stack is still open.

This replaces both sections with a note that the work is on main and that the owning specs in section 6 lead, keeping the PR table as an index of which PR introduced what — that survives the merge and is what makes a git blame hit on one of these branches legible. The dead Worktree column is dropped; the Branch column stays because the merge commits name those branches. Two later phrases that said "the stack" now say "Workspaces", since the reader no longer has a stack in front of them.

Sections 2 through 8 and the Transfer findings are untouched: the setup steps, the cargo test node-binary trap, the test inventory, the manual checklist, the "rules that bite", and the known gaps all describe main as it stands and are the reason to keep this file.

Nothing else in the repo links to this guide, so it is only findable by listing the repo root. If you want it reachable from the documented entry point, a one-line pointer in AGENTS.md would do it — held back here because it is a separate concern and lands against that file's spec-lint word budget.

No test: the change is documentation with no executable behavior. pnpm lint:specs and the five sibling lints report the same state as main (two pre-existing standalone/sidecar/node_modules path hits that only appear when dependencies are not installed).

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 15, 2026

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1627e92
Status: ✅  Deploy successful!
Preview URL: https://789b867b.mouseterm.pages.dev
Branch Preview URL: https://fix-workspaces-guide-poststa.mouseterm.pages.dev

View logs

@dormouse-bot dormouse-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback on work in progress, not a merge verdict — mark the PR ready when you want the full review.

The replacement text asserts the branches no longer exist, and all eleven are still on the remote: gh api repos/diffplug/dormouse/git/ref/heads/workspaces-window (and each of the other ten) resolves today. That matters here more than it would elsewhere, since accuracy about the current state is the whole reason for the edit — an agent that trusts the line will read origin/workspaces-fidelity in a fetch listing as a leftover it should clean up, or as evidence the guide is stale and stop trusting the rest of section 1. The merge is the durable fact; whether the branches get deleted later is not, so phrasing it as "merged and no longer worked on" stays true either way. Inline suggestion below.

The dates and the table check out: all eleven PRs merged 2026-09-15T02:00Z, and the merge commits on main do name the branches (Merge branch 'workspaces-harness' into workspaces-transfer-fixes), which is the justification for keeping the Branch column.

Comment thread TESTING_AND_MODIFICATION_GUIDE.md Outdated
@nedtwigg

Copy link
Copy Markdown
Member

this file will soon be deleted completely, no point editing it

@nedtwigg nedtwigg closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants