docs(dor-cli): describe argv-over-protocol; drop dead type decls#137
Merged
Conversation
PR #136 moved command quoting from `dor` to the host, but the dor-cli spec still described `dor` quoting + parent-process shell detection, and node-runtime.d.ts kept the `child_process`/`process.ppid` declarations that only the deleted `parentProcessName()` used. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
f3726d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://accbce9d.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-dor-cli-argv-spec-cleanu.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly sweep finding from reviewing PRs #121 and #136 (the
dorCLI expansion + argv-over-protocol change). PR #136 inverted command quoting —dornow forwards raw argv and the host quotes — but a couple of leftovers from the old parent-process-shell-detection path were missed.docs/specs/dor-cli.md— stale quoting descriptionThe spec still described the pre-#136 behavior: "Command tails ... are quoted by
dor...dordetects the invoking shell from its parent process when possible." That's no longer true.commandis now a rawstring[](seeEnsureSurfaceRequest/SplitSurfaceRequestindor/src/commands/types.ts), and the host does the quoting inlib/src/components/Wall.tsx(dorCommandString→buildShellCommandForKind(shellCommandKind(...))). Rewrote the paragraph to describe argv-over-protocol with host-side quoting and pointed the source-of-truth atdor/src/commands/shell-quote.ts.dor/src/node-runtime.d.ts— dead ambient declarationsThe
declare module 'node:child_process'(execFileSync) block andprocess.ppidexisted only for the deletedparentProcessName()helper. Nothing underdor/srcimportschild_processor readsppidanymore (verified by grep;tsc -p tsconfig.jsonstill passes after removal).generate-dor-version.mjsusesexecFileSyncbut it's a.mjsscript that doesn't consume this.d.ts.Verification
Docs-only + dead-type-declaration removal, so no new test. Confirmed
dorstill builds and all tests pass: